fix(messages): fix typos and misleading error messages in audit, dash…#210
Open
aaryan359 wants to merge 1 commit intofossology:mainfrom
Open
fix(messages): fix typos and misleading error messages in audit, dash…#210aaryan359 wants to merge 1 commit intofossology:mainfrom
aaryan359 wants to merge 1 commit intofossology:mainfrom
Conversation
…board and obligations Signed-off-by: aaryan359 <aaryanmeena96@gmail.com>
Contributor
Author
|
@deo002, Please look at this. Does this look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
"error fetching risk liicense frequencies"→"error fetching risk license frequencies"(doublei)"no license with id '%s' exists"; now correctly say"no audit with id '%s' exists"or"no changelog with id '%s' exists""Failed to update license"in obligation update/import paths were copy-pasted from the license handler; now correctly say"Failed to update obligation"Submitter Checklist
References
pkg/api/dashboard.go:101"error fetching risk liicense frequencies""error fetching risk license frequencies"pkg/api/audit.go:99— GetAudit"no license with id '%s' exists""no audit with id '%s' exists"pkg/api/audit.go:157— GetChangeLogs"no license with id '%s' exists""no audit with id '%s' exists"pkg/api/audit.go:224— GetChangeLogbyId (audit ID)"no license with id '%s' exists""no audit with id '%s' exists"pkg/api/audit.go:237— GetChangeLogbyId (changelog ID)"no license with id '%s' exists""no changelog with id '%s' exists""Failed to update license""Failed to update obligation"